Add Task, Epic and Spike card work-item types - #2949
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9fccd4979
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Independent review of c9fccd4 is complete. HIGH, fix-now: useCardModal.ts sets the card form's isSaving in handleSaveEditComment without resetting it. Both successful and rejected comment saves leave the form disabled and prevent a subsequent card save. Exact-source execution reproduced both paths; two committed-regression candidates also fail before the fix. One bounded fix batch removes the unrelated card-form assignments and verifies success/failure recovery. MEDIUM, tracked: a card/move proposal carrying unsupported extra workItemType data can claim a type transition in readable preview while Apply only moves it. Source-traced, not runtime-reproduced; tracked as #2950. Ordinary MCP create/update paths use supported payloads. No other findings in the separate persistence/editor and authority/proposal lenses. Current head is not merge-qualified until the HIGH fix, scoped verification and fresh exact-head CI complete. |
|
Round 2 resolves the confirmed HIGH at be6aaba. Comment editing no longer changes card-form saving/error state. Both new regressions failed before the fix and pass afterward; 106 affected component/composable tests, scoped ESLint and production build/typecheck pass. The independent reviewer reran the two new cases and returned SHIP. The other lens remains valid because backend and authority paths are unchanged. MEDIUM preview discrepancy remains tracked as #2950. No remaining CRITICAL/HIGH finding. Exact-head hosted CI and aging gate remain required. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be6aaba4d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Both review lenses are complete and the sole HIGH is fixed at be6aaba. The completed implementation worktree was removed after exact remote-head and ignored-file inventory checks. Logs, browser results, review diffs and RESUME.md are preserved at C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2946. Synthetic runtime database and generated build/dependency outputs were discarded; no owned browser/API listeners remain. Hosted CI is still pending. |
|
Current-base integration at 3341816 includes main be0e134. The only inbound change is the five-file Batch Apply announcement slice from merged #2948; this PR's implementation files are unchanged. Independent scoped review of that exact inbound delta returns SHIP: no effect on Inbox polling, card type/comment state, or backend WIP behavior, and no change to confirmation/Apply gating. Delta artifact SHA-256 B0E695DBAD9BA4AEF0BB8F78832A783C1D1749FA02A9565FEF346C717FF24021. Earlier original/fix reviews remain valid. Fresh hosted CI is running; not yet merge-qualified. |
|
Current-base qualification: integrated main fad4935 (#2945) at head 9735300. The inbound 29-file Inbox delta is disjoint from this PR's owned changes. Independent scoped interaction review found no blocker: status polling remains read-only and does not alter proposal or board writes. Existing source review and local proof remain applicable. Fresh exact-head hosted CI is pending; this comment does not qualify a pending gate as passed. |
|
Merge qualification at head 9735300, base fad4935: Required CI 34530704819 completed successfully; Extended, Smart CI and self-test also pass. No pending/failed checks or unresolved threads. The bounded review/fix cycle and current-base interaction review are complete; MEDIUM follow-ups remain #2950/#2952. Head has aged over 25 minutes. Expected reviewed tree: 1f253f8da65f8477aab4ff19f05a4df89a4fce63. Merging with a merge commit. |
1 participant
Cards can now be explicitly classified as Task, Epic or Spike. Existing cards and omitted create inputs default to Task; omitted update inputs preserve the saved type. The shared Paper and Legacy card editor saves type changes with the displayed card version and keeps a rejected draft available for recovery.
This vertical includes the additive migration, authorized API updates, review-first proposal operations and receipts, MCP reads/proposals, Board JSON portability and scoped account exports. Type changes preserve card identity, placement, labels, block and archive state. Quick create remains Task; card details provide type selection. Parent links and hierarchy remain separate under #2087.
Closes #2946.
Validation:
The first attempted red test failed on missing schema and is not claimed as a behavioral reproduction. Live providers and manual screen-reader output were not tested. UPGRADING documents the migration; STATUS is leased by #2947 and receives a coordinator sync packet.
Non-blocking review follow-ups: #2950 covers unsupported extra type fields in move-preview text; #2952 covers type-control recovery for older board payloads without canWrite. Both are tracked separately under the bounded review rule.