Skip to content

Exclude archived cards from new workspace analysis - #2957

Merged
Chris0Jeky merged 4 commits into
mainfrom
issue-2941/archived-observation-sources
Sep 10, 2026
Merged

Exclude archived cards from new workspace analysis#2957
Chris0Jeky merged 4 commits into
mainfrom
issue-2941/archived-observation-sources

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Archived cards could still be selected for new workspace observations because the source reader checked board archive state but not card archive state.

Exclude archived cards in that shared reader. The existing source, post-model and transactional-save checks now reject them consistently, while authorized card and observation history remain readable.

Closes #2941.

Validation:

  • Three regression cases failed before the predicate fix; all 21 focused API tests pass.
  • Fresh archived requests are rejected before provider/quota admission, even with the current fingerprint.
  • Archival during model execution or before commit discards candidates; history/outsider-read controls pass.
  • Full backend: 9,388 passed, five existing skips (dotnet test backend/Taskdeck.sln -c Release -m:1).
  • Documentation already promises archived-source rejection; docs and GitHub operations governance checks pass.

No frontend, provider or worker changes. No live-model quality or browser behavior is claimed.
Current-main integration at 8157a28 adds only the reviewed #2948 announcement UI; all 21 observation API tests pass again.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T21:41:04.077507Z 091363a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Independent adversarial review at 8157a28: SHIP, no findings. The reviewer traced pre-admission, post-model and transactional source checks and unchanged historical-read authorization. Stable-fingerprint archive races, current-fingerprint rejection, retained history and outsider denial are covered. Exact-head hosted CI remains pending.

Copy link
Copy Markdown
Owner Author

Completed worktree removed after tracked-tree, remote-head and ignored-file inventory checks. Red/green/full/integration logs, review diff and cleanup inventory are retained at C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2941. Only generated build outputs discarded. Implementation claim stays review-only until merge.

Copy link
Copy Markdown
Owner Author

Current-base qualification: integrated main fad4935 (#2945) at head 9e81afd. The inbound 29-file Inbox delta is disjoint from this PR's owned changes. Independent scoped interaction review found no blocker: status polling remains read-only and does not alter proposal or board writes. Existing source review and local proof remain applicable. Fresh exact-head hosted CI is pending; this comment does not qualify a pending gate as passed.

Copy link
Copy Markdown
Owner Author

Current-base qualification at 091363a: merged main7695211a0d31590c19845fd0e4cd559be521384e (#2949). Independent scoped review found no interaction blocker. The inbound 41-file type payload is byte-identical across the four Alpha candidates (SHA2566F80C8B1197DCDB73E63FF728DAF14A65645B1B2D2767DB410E95F57A7D95EBF), and this PR's owned paths are disjoint. Original source review stands; this was a read-only source/diff interaction pass, not new test execution. Fresh exact-head hosted CI remains required and pending.

@Chris0Jeky
Chris0Jeky merged commit 93ca1cd into main Sep 10, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 10, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-2941/archived-observation-sources branch September 10, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Exclude archived cards from new workspace observation sources

1 participant